Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

Problem

  • lack of centralization for configuration options
  • no way to configure manifest url without changing the code directly
  • overriding the language server location will only work right now for amazonqLSP and not workspace context

Solution

  • Fix all of the above

TODO

  • In another PR i'll do the same thing for the workspace context language server

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner February 13, 2025 14:55
@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jpinkney-aws jpinkney-aws merged commit f3cbf0e into aws:feature/amazonqLSP Feb 13, 2025
16 of 23 checks passed
jpinkney-aws added a commit that referenced this pull request Feb 19, 2025
#6581)

## Problem
Followup to #6570 but for
the workspace context language server

## Solution
- dev setting/environment variable overrides for setting manifest, id,
supportedVersions, development override
- extract the common lsp installer functionality to a base lsp installer
class
- add new tests exercising the config
- rename lspResolver -> lspInstaller

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants